HELP!! No crank
 

So i have a 1996 318ti and it won't crank at all, the lights and ac inside All work, starter has power to it and also a brand new battery, and a new ignition switch.... But it still will not crank!! Can anyone help with this problem i'm so confused

Sounds like your starter is done.

I'd check for voltage to the starter first. Could be the clutch or neutral switch.

OP mentioned that he has power to starter. But can double check clutch safety or auto trans switch. If it has been working fine up to this point and just stopped, more likely the starter itself.

I have another suspicion. OP mentioned a new ignition switch (but what about the key?), and if it isn't properly aligned with the EWS, the car will not start.

Something else that you can quickly check: does your fuel gauge show empty when you turn the key? There's one fuse, I don't remember which one, but when it blows, it kills the fuel gauge, a few other indicators on the dashboard, AND it prevents the engine from starting.

While you're at it, check all the fuses.

When you say "starter has power to it" - where are you measuring it? These starters have 3 terminals on them. The big fat terminal in the middle is connected to the alternator and the battery. One of the smaller ones operates the solenoid. I don't know what the third one does.

Good call. Yes the large terminal is direct to battery/alternator and is always hot. The smaller of the two terminals is only hot when the key is turned to the start position and EWS is sending the signal to start. The larger (mid sized) black wire is the ground for the starter. You need to see if you have power on the signal wire when the key is turned to start. If no power when key is turned to start, check the starter relay and then (as wolferj said) your EWS.

When you say ignition switch, do you mean the tumbler (where you stick the key) or the actual switch on the opposite side? If the tumbler did you make sure to fully reconnect the black ring and wire for it that goes over the keyway? If that isn't connected properly you will never send a signal to the EWS.

Let us know what you find out.